refactor: remove claude wrapper, run claude directly#65
Merged
Conversation
The wrapper script passed --bare and --dangerously-skip-permissions to claude, but both are already handled by config files: - settings.json: defaultMode=bypassPermissions, skipDangerousModePermissionPrompt=true - claude.json: hasCompletedOnboarding=true Remove the wrapper, stop moving the real binary to claude-real in the Dockerfile, and let the base image's claude run directly.
Place the agent instructions at /sandbox/.claude/CLAUDE.md (the user's global CLAUDE.md path) instead of /sandbox/CLAUDE.md. Claude Code reads this automatically without needing it in the working directory.
Base CLAUDE.md is now generic (sandbox environment only). At startup, provider-specific tool docs are appended based on which credentials are available: - GitHub: appended when gh is authenticated - Jira/Confluence: appended when JIRA_URL is set - GWS: appended when GOOGLE_WORKSPACE_CLI_TOKEN is set This way the agent only sees docs for tools it can actually use.
This reverts commit feb54bc.
startup.sh was sourcing a sandbox.env file that nothing generates and running gh auth setup-git which was duplicated in run.sh. Remove both. Agent now runs gh auth setup-git on demand when it needs git auth, guided by CLAUDE.md instructions. Env vars are injected via --env on sandbox create, no env file needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sandbox/bin/claude) that passed--bare --dangerously-skip-permissions— both are already handled by config files:settings.json:defaultMode=bypassPermissions,skipDangerousModePermissionPrompt=trueclaude.json:hasCompletedOnboarding=trueclaude-realin the Dockerfile — claude runs directly from the base image--barefrom test entrypoints and test-flow smoke testTest plan
make testpassesclaudestarts clean inside a sandbox (no onboarding, no permission prompts)